Re: [-mm PATCH] set enable bit instead of lock bit of Watchdog Timer in Intel 6300 chipset

From: David Härdeman
Date: Mon Aug 15 2005 - 17:12:55 EST


On Mon, Aug 15, 2005 at 02:21:05PM -0700, Naveen Gupta wrote:

This patch sets the WDT_ENABLE bit of the Lock Register to enable the
watchdog and WDT_LOCK bit only if nowayout is set. The old code always
sets the WDT_LOCK bit of watchdog timer for Intel 6300ESB chipset. So, we
end up locking the watchdog instead of enabling it.

Naveen,

thanks alot for testing the driver further and finding these bugs. I've not been able to do so myself as the only computers available to me with this watchdog are production-servers meaning that I've only been able to test during scheduled downtimes.

Have you tested and verified that the driver works after these patches have been applied?

Re,
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/