Re: [PATCH] Permissions don't stick on ConfigFS attributes

From: Daniel Phillips
Date: Sat Aug 20 2005 - 01:20:50 EST


On Saturday 20 August 2005 11:22, Jon Smirl wrote:
> A patch for making sysfs attributes persistent has recently made it
> into Linus' tree.
>
>
http://article.gmane.org/gmane.linux.hotplug.devel/7927/match=sysfs+permissions

Interesting, it handles more than just the file mode. But does anybody really
care about the ctime/atime/mtime in sysfs? I can see how uid and gid could
be useful. My way of handling this (by copying out the potentially changed
iattrs when the dentry is destroyed) looks more compact than Maneesh's
solution, while not being any less effective, once I get it right that is.
Does sysfs really need its own setattr?

A quibble: we normally use the term persistent to mean "saved on permanent
storage". Going by that, Maneesh just fixed a bug and did not make iattrs
persistent.

Regards,

Daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/