Re: [2.6 patch] include/linux/quotaops.h: "extern inline" doesn't make sense

From: Jan Kara
Date: Mon Aug 22 2005 - 17:20:07 EST


> "extern inline" doesn't make sense.
>
>
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
Looks good.

Signed-off-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
>
> include/linux/quotaops.h | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.13-rc6-mm1/include/linux/quotaops.h.old 2005-08-20 14:40:53.000000000 +0200
> +++ linux-2.6.13-rc6-mm1/include/linux/quotaops.h 2005-08-20 14:41:30.000000000 +0200
> @@ -198,38 +198,38 @@
> #define DQUOT_SYNC(sb) do { } while(0)
> #define DQUOT_OFF(sb) do { } while(0)
> #define DQUOT_TRANSFER(inode, iattr) (0)
> -extern __inline__ int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_PREALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_add_bytes(inode, nr);
> return 0;
> }
>
> -extern __inline__ int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_PREALLOC_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_PREALLOC_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
> return 0;
> }
>
> -extern __inline__ int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_ALLOC_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_add_bytes(inode, nr);
> return 0;
> }
>
> -extern __inline__ int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
> +static inline int DQUOT_ALLOC_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_ALLOC_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
> return 0;
> }
>
> -extern __inline__ void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> +static inline void DQUOT_FREE_SPACE_NODIRTY(struct inode *inode, qsize_t nr)
> {
> inode_sub_bytes(inode, nr);
> }
>
> -extern __inline__ void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
> +static inline void DQUOT_FREE_SPACE(struct inode *inode, qsize_t nr)
> {
> DQUOT_FREE_SPACE_NODIRTY(inode, nr);
> mark_inode_dirty(inode);
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/