Re: [PATCH 2.6.12.5 1/2] lib: allow idr to be used in irq context

From: Andrew Morton
Date: Mon Aug 22 2005 - 17:57:41 EST


James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:
>
> Since you won't post the usage code, just answer this: how does what
> you're doing with idr differ from its originally designed consumer: the
> posix timers which also do the idr_remove() in IRQ context?

erp. posix_timers has its own irq-safe lock, so we're doing extra,
unneeded locking in that code path.

I think providing locking inside idr.c was always a mistake - generally we
rely on caller-provided locking for such things.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/