Re: skge missing ifdefs.

From: Al Viro
Date: Tue Aug 23 2005 - 01:00:10 EST


On Tue, Aug 23, 2005 at 12:24:19AM +0200, Roman Zippel wrote:
> Hi,
>
> On Mon, 22 Aug 2005, Andrew Morton wrote:
>
> > Al Viro <viro@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > >
> > > mail -s '[PATCH] (45/46) %t... in vsnprintf' torvalds@xxxxxxxx <<'EOF'
> >
> > <wonders what the other 45 patches did>
> >
> > Could you copy a mailing list on patches, please?
>
> Seconded.
> Al, I'd like to know which of the m68k related patches you want to merge.

See ftp.linux.org.uk/pub/people/viro/patchset/T* + adb.h delta from CVS.
That's a minimum getting mainline m68k to sane state and not breaking
other platforms. These are against -rc6-git2, but their counterparts
in more recent patchset have not changed. BTW, m68k patches were not
in the series sent to Linus and I would definitely Cc m68k folks on them
if they would go there.

As for your s/thread_info/stack/ - I don't believe it's doable in mainline
right now. It's definitely separate from m68k merge and should not be
mixed into it. Moreover, mandatory changes to every platform arch-specific
code over basically cosmetic issue (renaming a field of task_struct) at
this point are going to be gratitious PITA for every architecture with
out-of-tree development. And m68k folks, of all people, should know what
fun it is.

When folks start using task_thread_info() in arch/* (i.e. by 2.6.1[45]) the
size of that delta will go down big way and it will be less painful. Until
then... Not a good idea.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/