Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

From: Al Viro
Date: Wed Aug 24 2005 - 11:28:51 EST


On Wed, Aug 24, 2005 at 09:22:27AM -0700, Roland Dreier wrote:
> Al> infiniband uses PCI helpers all over the place (including the
> Al> core parts) and won't build without PCI.
>
> I don't think this is the right fix. The only PCI helpers used in
> code that is enabled with CONFIG_PCI=n are pci_unmap_addr_set() and
> pci_unmap_addr(). And they're only used because no one has added
> dma_unmap_addr_set() and dma_unmap_addr() -- the core code is properly
> using the general dma_xxx API wherever possible.
>
> There actually is non-PCI InfiniBand hardware coming, so we'll have to
> fix this properly at some point.

I'm all for it and removing BROKEN from Kconfig when fixes happen is
obviously not a problem at all ;-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/