Re: [PATCH 3/3] exterminate strtok - usr/gen_init_cpio.c

From: Jesper Juhl
Date: Wed Aug 24 2005 - 16:16:06 EST


On 8/24/05, Horst von Brand <vonbrand@xxxxxxxxxxxx> wrote:
> Jesper Juhl <jesper.juhl@xxxxxxxxx> wrote:
[snip]
>
> > - if ('\n' == *type) {
> > + if (!*type || '\n' == *type) {
>
> Redundant. If *type == '\n', it is certainly != 0.

Hmm, I added that since if we get past the if above it, then "type"
might be !=NULL, but *type might be, but you are right, it's still
redundant since there's a check below that'll catch it if so.

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/