Re: VIA Rhine ethernet driver bug (reprise...)

From: Roger Luethi
Date: Fri Aug 26 2005 - 04:06:13 EST


On Fri, 26 Aug 2005 03:49:25 -0400, Jeff Garzik wrote:
> Denis Vlasenko wrote:
> >May be a known problem. A buglet in MII common code.
> >Via-rhine maintainer knows about it, as does Jeff.
>
> You don't speak for me, sir.
>
> I know of no such problem. Please submit a report and/or patch.

I believe vda may have been referring to this. I can send you the
original thread if it's not in your mail archive.

Roger

------------------------------ cut here ------------------------------
From: Roger Luethi <rl@xxxxxxxxxxx>
Subject: Re: via-rhine + link loss + autoneg off == trouble
To: Denis Vlasenko <vda@xxxxxxxxxxxxx>, Jeff Garzik <jgarzik@xxxxxxxxx>
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx,
linux-kernel@xxxxxxxxxxxxxxx
Date: Sat, 13 Aug 2005 20:34:21 +0200
User-Agent: Mutt/1.5.8i

Jeff, can you tune in for a moment?

First of all, many thanks to vda for tracking this down, and to everyone
else who helped with it.

I had a look at my code and at 8139cp (which is one of only a handful
of drivers that have been converted to use the generic MII stuff).

Turns out 8139cp doesn't seem to do anything to address the problem
vda described, either, so it is equally affected. Is this something we
should fix in mii.c, or is mii_check_media working as designed? Btw,
I'd be thrilled if someone wrote a few lines per function in mii.c:
purpose, preconditions, side effects, something along these lines.

Roger
------------------------------ cut here ------------------------------

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/