Re: [patch 2/3] x86_64: Run setup_per_cpu_areas and trap_init sooner

From: Andi Kleen
Date: Mon Aug 29 2005 - 14:56:37 EST



> +void __init early_setup_per_cpu_areas(void)
> +{
> + static char cpu0[PERCPU_ENOUGH_ROOM]
> + __attribute__ ((aligned (SMP_CACHE_BYTES)));

This needs a __cacheline_aligned too, otherwise there could be false sharing.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/