Re: [PATCH] isdn_v110 warning fix

From: Alexey Dobriyan
Date: Tue Aug 30 2005 - 03:11:44 EST


On Tue, Aug 30, 2005 at 01:05:43AM +0200, Jesper Juhl wrote:
> drivers/isdn/i4l/isdn_v110.c:523: warning: `ret' might be used uninitialized in this function

> --- linux-2.6.13-orig/drivers/isdn/i4l/isdn_v110.c
> +++ linux-2.6.13/drivers/isdn/i4l/isdn_v110.c
> @@ -516,11 +516,11 @@

> -isdn_v110_stat_callback(int idx, isdn_ctrl * c)
> +isdn_v110_stat_callback(int idx, isdn_ctrl *c)
> {
> isdn_v110_stream *v = NULL;
> int i;
> - int ret;
> + int ret = 0;

ret is used only in isdn_v110_stat_callback()::case ISDN_STAT_BSENT.
It's possible for it to be unused only if passed c->parm.length is 0.
Do you see codepaths that can do it?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/