Re: [PATCH 2.6.13] libata: Marvell SATA support (PIO mode)

[Jeff Garzik]

Christoph Hellwig wrote:
> Stop that crap now please.  Adding "scsi.h" includes is _not_ allowed
> for new drivers, period.  There's no exceptions, not even for
> Jeff "I'm part of the calal" Garzik.

There are solid technical reasons (a) why libata drivers include scsi.h, 
and (b) why all libata drivers look similar.  It -impedes- maintenance 
to have one libata driver different from all the others, and this is 
what you are suggesting.

Your suggestion causes nothing but additional work, for zero gain:  as I 
have explained, all the scsi.h includes will go away at the same time. 
Such as sweep would catch all libata drivers, including sata_mv.

Until you're willing to step up and help with 2.4.x maintenance, you're 
just being an impediment for non-technical reasons.  If you want to do 
that, join politics and become a politician.  I have real work to do.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/