Re: Serial driver (serial_core.c) status messages should be set toKERN_INFO

[Jiri Slaby]

Ben Dooks napsal(a):

> On Thu, Sep 01, 2005 at 10:38:26PM +0200, Jiri Slaby wrote:
>  
>
> > Alon Bar-Lev napsal(a):
> >    
> >
> > > static inline void
> > >
> > > uart_report_port(struct uart_driver *drv, struct uart_port *port)
> > > {
> > > -        printk("%s%d", drv->dev_name, port->line);
> > > +      printk(KERN_INFO + "%s%d", drv->dev_name, port->line);
> > >      
> > plus sign between that?
> >
> >    
> >
> > >       printk(" at ");
> > >      
> > why the fellows didn't put this to the line above?
> >    
> >
> > >       switch (port->iotype) {
> > >       case UPIO_PORT:
> > >               printk("I/O 0x%x", port->iobase);
> > >      
> > And what about these?
> >    
>
> looks like they're not on a newline, so need no severity.
>  
ok, ok, but isn't this a little bit racy (so you can see dev_name and 
line, then another driver's info and then " at ", then something else...)

regards,

--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@xxxxxxxxx      ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/