RE: [PATCH 1/1] Implement shared page tables

[Dave McCracken]

--On Thursday, September 01, 2005 18:58:23 -0700 "Chen, Kenneth W"
<kenneth.w.chen@xxxxxxxxx> wrote:

>> +		prio_tree_iter_init(&iter, &mapping->i_mmap,
>> +				    vma->vm_start, vma->vm_end);
> 
> 
> I think this is a bug.  The radix priority tree for address_space->
> i_mmap is keyed on vma->vm_pgoff.  Your patch uses the vma virtual
> address to find a shareable range, Which will always fail a match
> even though there is one.
>
> Do you really have to iterate through all the vma?  Can't you just break
> out of the while loop on first successful match and populating the pmd?
> I would think you will find them to be the same pte page. Or did I miss
> some thing?

Man, I spaced that whole search code.  I was sure I'd tested to make sure
it was finding matches.  I'll fix all that up in my next release.

Dave McCracken

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/