Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver
From: Harald Welte
Date: Sun Sep 04 2005 - 02:34:31 EST
Hi Nish,
thanks for your comments.
On Sat, Sep 03, 2005 at 03:13:43PM -0700, Nish Aravamudan wrote:
> On 9/3/05, Chase Venters <chase.venters@xxxxxxxxxxxx> wrote:
> > > Below you can find a driver for the Omnikey CardMan 4040 PCMCIA
> > > Smartcard Reader.
> >
> > #define CCID_DRIVER_BULK_DEFAULT_TIMEOUT (150*HZ)
>
> These are all fine. Although I am a bit suspicious of 150 second
> timeouts; but if that is the hardware...
That's a definition from the original vendor-supplied driver.
Unfortunately there's no hardware documentation, so I can't verify it.
But generally speaking, serial smart cards can really be slow, so I
think it could make sense.
> > /* how often to poll for fifo status change */
> > #define POLL_PERIOD (HZ/100)
>
> This needs to be msecs_to_jiffies(10), please.
thanks, changed in my local tree now.
> Of bigger concern to me is the use of the sleep_on() family of
> functions, all of which are deprecated.
Ok, I'm working on replacing the respective code with
wait_event_interruptible_timeout().
--
- Harald Welte <laforge@xxxxxxxxxxxx> http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
Attachment:
pgp00000.pgp
Description: PGP signature