Re: [PATCH] New: Omnikey CardMan 4040 PCMCIA Driver

From: Harald Welte
Date: Mon Sep 05 2005 - 04:14:37 EST


On Sun, Sep 04, 2005 at 02:58:27PM +0200, Ingo Oeser wrote:

> just use
> return nonseekable_open(inode, filp);
>
> to really disable any file pointer positioning (e.g. pwrite/pread too).
>
> Addtionally cmx_llseek() is implement already as "no_llseek()"
> by the VFS, so you delete it from the driver an use no_llseek() from
> the VFS instead.

great, thanks, I've merged your suggested changes into my local tree.
Stay tuned for a re-submit later today.

--
- Harald Welte <laforge@xxxxxxxxxxxx> http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)

Attachment: pgp00000.pgp
Description: PGP signature