Re: [PATCH] Omnikey Cardman 4000 driver

[Jesper Juhl]

On 9/6/05, Harald Welte <laforge@xxxxxxxxxxxx> wrote:
> Hi!
> 
> Following-up to the Cardman 4040 driver, I'm now sumitting a driver for
> the Cardman 4000 reader.  It is, too, a PCMCIA smartcard reader and the
> predecessor of the 4040.
> 
> From a technical point of view, the two devices have nothing in common,
> so there is no possibility of code sharing.
> 
> Please consider mergin mainline, thanks.
> 
> Note: The patch is incremental to the Cardman 4040 driver that has
> already been submitted.
> 
[snip]

Please see my CodingStyle comments for your previous driver as well as
the cleanup patch I just posted for that one. A lot of those issues
apply to your new driver as well - care to clean that up?

-- 
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/