Re: [-mm patch 2/5] SharpSL: Add cxx00 support to the Corgi LCD driver

[Pekka Enberg]

On 9/6/05, Richard Purdie <rpurdie@xxxxxxxxx> wrote:
> > +/*
> > + * Corgi/Spitz Touchscreen to LCD interface
> > + */
> > +unsigned long inline corgi_get_hsync_len(void)
> > +{
> > +       if (machine_is_corgi() || machine_is_shepherd() || machine_is_husky()) {
> > +#ifdef CONFIG_PXA_SHARP_C7xx
> > +               return w100fb_get_hsynclen(&corgifb_device.dev);
> > +#endif
> > +       } else if (machine_is_spitz() || machine_is_akita() || machine_is_borzoi()) {
> > +#ifdef CONFIG_PXA_SHARP_Cxx00
> > +               return pxafb_get_hsync_time(&pxafb_device.dev);
> > +#endif
> > +       }
> > +       return 0;
> > +}

On 9/6/05, Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote:
> Please consider making two version of corgi_get_hsync_len() instead
> for both config options. The above is hard to read.

Uhm, forget it. I didn't realize both config options can be enabled at
the same time. Sorry for the noise.

                                          Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/