Re: [patch 1/1] ipw2100: remove by-hand function entry/exit debugging

[Jeff Garzik]

David S. Miller wrote:
> From: Jeff Garzik <jgarzik@xxxxxxxxx>
> Date: Tue, 06 Sep 2005 21:51:21 -0400
>
>
> > NAK.  Rationale: maintainer's choice.  Pavel doesn't get to choose
> > the debugger of choice for the driver maintainer.
>
>
> If it makes the driver unreadable and thus harder to maintain,
> I think such changes should seriously be considered.
>
> Most of the DEBUG_INFO macro usage is fine, but those "enter"
> and "exit" ones are just pure noise and should be removed.

I find them useful in my own drivers; they are definitely not pure noise.

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/