Re: [WATCHDOG] v2.6.13 watchdog-patches

From: Wim Van Sebroeck
Date: Wed Sep 07 2005 - 03:22:32 EST


Hi Arjen,

> this looks ENTIRELY like the wrong solution!

To be honoust: I'm not in favour of using refcounts unnecessarily either.

> Isn't it a LOT easier to just del_timer_sync() the timer from the module
> exit code? Mucking with module refcounts in a driver is almost always a
> sign of a bug or at least really bad design, and I think that is the
> case here.....

However, the goal is to make sure that the "watchdog" stays running and
watches the system and that it in case of abnormal behaviour reboots the system.
And you can't get that if you delete the timer.

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/