Re: [PATCH] i386 CFI annotations

[Tom Rini]

On Thu, Sep 08, 2005 at 05:10:29PM +0200, Jan Beulich wrote:

> As a foundation for reliable stack unwinding, this adds CFI unwind
> annotations to many low-level i386 routines, plus a config option
> (available to all architectures) to enable them as well as the
> compiler
> producing similar information for all C sources.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

x86_64 has proper CFI annotations on things, and just depends on
DEBUG_INFO.  Perhaps that would be a slightly easier path to use for
pushing this along?

> +	CFI_ADJUST_CFA_OFFSET 4;\
> +	/*CFI_REL_OFFSET es, 0;*/\
>  	pushl %ds; \
> +	CFI_ADJUST_CFA_OFFSET 4;\
> +	/*CFI_REL_OFFSET ds, 0;*/\

Adding new commented out code never wins new friends. :)

> diff -Npru 2.6.13/include/asm-i386/dwarf2.h
[snip]
> +#ifdef CONFIG_UNWIND_INFO
[snip]
> +#else
[snip]
> +#define CFI_STARTPROC	ignore

Why not just empty defines?

-- 
Tom Rini
http://gate.crashing.org/~trini/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/