Re: [PATCH 2/25] NTFS: Allow highmem kmalloc() in ntfs_malloc_nofs()and add _nofail() version.

From: Pekka J Enberg
Date: Fri Sep 09 2005 - 07:03:07 EST


On Fri, 9 Sep 2005, Anton Altaparmakov wrote:
> > I completely disagree with you given that this is not "inventing [...]
> > own memory allocators", it is just a convenient short hand. I am sure a
> > lot of people would agree with you though. It is just a matter of
> > personal preference.
>
> I should add that this is not ntfs only, the idea is from another file
> system which uses it, too. Can't remember which one it was, though (xfs
> maybe?).

Indeed. It is not just a matter of personal preference but also a matter
of subsystems introducing duplicate code like this. Quick grepping shows
UDF doing same thing and XFS doing slightly differently but I am pretty
sure I've seen it elsewhere too.

Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/