PROBLEM: sk98lin misbehaves with D-Link DGE-530T which doesn't havereadable VPD

From: Josip Loncaric
Date: Fri Sep 09 2005 - 12:50:08 EST


Driver sk98lin makes repeated attempts to read VPD even after the first VpdInit() fails. This is wrong.

Lots of people seem to be getting repeated "Vpd: Cannot read VPD keys" errors. When nifd is active, this can happen every second, causing kernel stalls that disrupt time-critical operations (e.g. DVD use).

Inexpensive cards like D-Link DGE-530T may lack a readable VPD, so there is no point in trying to access this missing feature and causing brief system stalls (see https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=136158).

Can sk98lin be enhanced to give up on VPD after the first VpdInit() fails? The NIC appears to operate stably even without a readable VPD.

I haven't tested the experimental driver skge, but the same comment may apply. Obviously it makes no sense to repeatedly look for VPD keys when the VPD is missing or incorrect.

Sincerely,
Josip
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/