Re: List of things requested by lkml for reiser4 inclusion (to review)

From: Christoph Hellwig
Date: Fri Sep 09 2005 - 14:00:35 EST


On Fri, Sep 09, 2005 at 07:57:40PM +0100, Christoph Hellwig wrote:
> A very annoying small thing that comes to mind is the usage of
> reiser4_internal. Please remove it, all but exported symbol are
> module-private.

Oh, one other things that's totally annoying and makes reading the
code a pain are the line-length and comment style. Please wrap
lines after 80 chars and use normal

/* foobar, blagg */

or

/*
* fvsfafsfasdrfasddddddddddddddddddddd
* fdsfsfdsfsdf
* sdfsdfs
*/

comments, thanks

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/