Re: [PATCH 2.6.13 5/14] sas-class: sas_discover.c Discover process(end devices)

[Luben Tuikov]

On 09/09/05 15:59, Nish Aravamudan wrote:
> On 9/9/05, Luben Tuikov <luben_tuikov@xxxxxxxxxxx> wrote:
> 
>>Signed-off-by: Luben Tuikov <luben_tuikov@xxxxxxxxxxx>
> 
> 
> <snip>
> 
> 
> +static int sas_execute_task(struct sas_task *task, void *buffer, int size,
> +                           int pci_dma_dir)
> 
> <snip>
> 
> +                       set_current_state(TASK_INTERRUPTIBLE);
> +                       schedule_timeout(HZ);
> 
> <snip>
> 
> +                               set_current_state(TASK_INTERRUPTIBLE);
> +                               schedule_timeout(5*HZ);
> 
> Can you use msleep_interruptible() here? I don't see wait-queues in
> the immediate vicinity. If not, and you're going for the normal -mm
> route (and from there to mainline), can you use
> schedule_timeout_interruptible(), please?

Yes, sure.  I don't see why not.

	Luben

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/