Re: [GIT PATCH] More PCI patches for 2.6.13

From: Jeff Garzik
Date: Fri Sep 09 2005 - 20:28:58 EST


Linus Torvalds wrote:

On Fri, 9 Sep 2005, Andrew Morton wrote:

If something like a PCI power management function fails then it will likely
cause suspend or resume to malfunction, and we have a lot of such problems.


No, for several reasons.

First off, some of those functions can't fail in normal usage. Thus telling people that they have to check the return code is insane.

Secondly, at least some of the suspend failures have historically been
because drivers returned errors for no good reason. Adding yet another broken reason to return error is not going to help.

Agreed.

Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/