Re: [RFC] [PATCH] make add_taint() inline

[Kyle Moffett]

On Sep 11, 2005, at 13:44:37, donate wrote:
> From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> add_taint() is a trivial function.
> No need to call it out-of-line, just make it inline and
> remove its export.

Actually, in this case it might be better to leave add_taint
exported, add and export a new function get_taint(), and then
remove all export of the variable "tainted".  I've actually
seen one case where some module removed taint bits.  I don't
remember where or why, but it seemed really bad at the time,
and still does.  Also, does the tainted variable need any
kind of locking?  What happens if two CPUs try to taint the
kernel simultaneously?

Cheers,
Kyle Moffett

--
Premature optimization is the root of all evil in programming
  -- C.A.R. Hoare



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/