Re: [RFC] [PATCH] make add_taint() inline

From: Randy.Dunlap
Date: Sun Sep 11 2005 - 17:53:36 EST


On Sun, 11 Sep 2005 12:44:34 -0700 Andrew Morton wrote:

> donate <donate@xxxxxxxxxxx> wrote:
> >
> > From: donate <donate@xxxxxxxxxxx>
>
> Who is this?

Just some little mistake that I have since corrected.
Sorry about that.

> > From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
>
> > add_taint() is a trivial function.
> > No need to call it out-of-line, just make it inline and
> > remove its export.
>
> Well, presumably add_taint() was exported to modules for a reason. If that
> reason was valid then this patch requires that `tainted' be exported to
> modules too. And that allows naughty modules to trivially zero it out.

Got it, thanks. That's why it said [RFC].

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/