Re: [PATCH] drivers/char/isicom old api rewritten (round 3)

From: Greg KH
Date: Mon Sep 12 2005 - 00:01:50 EST


On Mon, Sep 12, 2005 at 01:11:00AM +0200, Jiri Slaby wrote:
> > > >40k isn't large - please include such patches in the email.
> > > >
> > > Thank you, Andrew, for your reply and hints, you sent.
> > Did everything get addressed?
> Maybe not, if you still want it in e-mail as plaintext, grr.
>
> > Then send the patch, cc'ed to the mailing list as per
> > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt, thanks.
> Oops, I read only SubmittingPatches. So this file should be changed in point 7
> (that not everybody wants URLs).
>
>
>
> This patch removes old api in pci probing and replaces it with new. Firmware
> loading added.

You do a lot of different things in this patch (whitespace changes, line
wrapps, etc.) Try a few patches in order (coding style issues, then pci
api, then firmware, etc.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/