Re: [1/3] Add 4GB DMA32 zone

From: Andi Kleen
Date: Mon Sep 12 2005 - 07:55:01 EST


On Monday 12 September 2005 14:50, Roman Zippel wrote:
> Hi,
>
> On Mon, 12 Sep 2005, Andi Kleen wrote:
> > > > -#define MAX_NR_ZONES 3 /* Sync this with ZONES_SHIFT */
> > > > -#define ZONES_SHIFT 2 /* ceil(log2(MAX_NR_ZONES)) */
> > > > +#define MAX_NR_ZONES 4 /* Sync this with ZONES_SHIFT */
> > > > +#define ZONES_SHIFT 3 /* ceil(log2(MAX_NR_ZONES)) */
> > >
> > > Why needs ZONES_SHIFT to be increased?
> > >
> > > > -#define FLAGS_RESERVED 8
> > > > +#define FLAGS_RESERVED 9
> > >
> > > I would prefer to keep this at 8.
> >
> > sparsemem needs these two.
>
> What two? What are you talking about???

The two changes you quoted.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/