Re: -git11 breaks parisc and sh even more

From: Alexey Dobriyan
Date: Tue Sep 13 2005 - 15:27:38 EST


On Tue, Sep 13, 2005 at 08:57:59PM +0200, Sam Ravnborg wrote:
> On Tue, Sep 13, 2005 at 09:47:54PM +0400, Alexey Dobriyan wrote:
> > 2.6.13-git10 was OK (read: allmodconfig still broken, but not _that_
> > early).

> > parisc:
> >
> > 2.6.13-git11

> > CC arch/parisc/kernel/asm-offsets.s
> > In file included from include/asm/spinlock.h:4,
> > from include/asm/bitops.h:5,
> > from include/linux/bitops.h:77,
> > from include/linux/thread_info.h:20,
> > from include/linux/spinlock.h:53,
> > from include/linux/capability.h:45,
> > from include/linux/sched.h:7,
> > from arch/parisc/kernel/asm-offsets.c:31:
> > include/asm/system.h:174: error: parse error before "pa_tlb_lock"

> > In file included from include/linux/spinlock_types.h:13,
> > from include/linux/spinlock.h:80,
> > from include/linux/capability.h:45,
> > from include/linux/sched.h:7,
> > from include/linux/mm.h:4,
> > from arch/sh/kernel/asm-offsets.c:13:
> > include/asm/spinlock_types.h:16: error: parse error before "atomic_t"

> I have tried to understand why this happens with no success..
> Not much has changed in how we actually compile the .c -> .s files.
> In both cases it looks like gcc is warning that a sane typedef is not
> present.
>
> Have you tried to dive more into this, or have you just reported the
> breakage?

fb1c8f93d869b34cacb8b8932e2b83d96a19d720 is first bad commit
diff-tree fb1c8f93d869b34cacb8b8932e2b83d96a19d720 (from 4327edf6b8a7ac7dce144313947995538842d8fd)
Author: Ingo Molnar <mingo@xxxxxxx>
Date: Sat Sep 10 00:25:56 2005 -0700

[PATCH] spinlock consolidation

This patch (written by me and also containing many suggestions of Arjan van
de Ven) does a major cleanup of the spinlock code. It does the following
things:

[snip]

arm, i386, ia64, ppc, ppc64, s390/s390x, x64 was build-tested via
crosscompilers. m32r, mips, sh, sparc, have not been tested yet, but should
be mostly fine.

P. S.: git bisect absolutely rocks! 10 minutes.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/