Re: [patch 2/7] s390: 3270 fullscreen view.

From: Christoph Hellwig
Date: Wed Sep 14 2005 - 11:10:46 EST


On Wed, Sep 14, 2005 at 05:53:45PM +0200, Martin Schwidefsky wrote:
> [patch 2/7] s390: 3270 fullscreen view.
>
> From: Richard Hitt <rbh00@xxxxxxxxxxxxx>
> From: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> Fix fullscreen view of the 3270 device driver.
>
> Signed-off-by: Richard Hitt <rbh00@xxxxxxxxxxxxx>
> Signed-off-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
>
> diffstat:
> arch/s390/kernel/compat_ioctl.c | 9 +
> drivers/s390/char/con3270.c | 7 -
> drivers/s390/char/fs3270.c | 234 +++++++++++++++++++++++++++++++++-------
> drivers/s390/char/raw3270.c | 100 +++++++++++++++--
> drivers/s390/char/raw3270.h | 7 +
> drivers/s390/char/tty3270.c | 27 ++--
> 6 files changed, 315 insertions(+), 69 deletions(-)
>
> diff -urpN linux-2.6/arch/s390/kernel/compat_ioctl.c linux-2.6-patched/arch/s390/kernel/compat_ioctl.c
> --- linux-2.6/arch/s390/kernel/compat_ioctl.c 2005-08-29 01:41:01.000000000 +0200
> +++ linux-2.6-patched/arch/s390/kernel/compat_ioctl.c 2005-09-14 16:48:15.000000000 +0200
> @@ -18,6 +18,8 @@
> #include <asm/dasd.h>
> #include <asm/cmb.h>
> #include <asm/tape390.h>
> +#include <asm/ccwdev.h>
> +#include "../../../drivers/s390/char/raw3270.h"

Umm, no. Please implement a compat_ioctl methods for the driver instead.
a volunteer ;-)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/