Re: [PATCH 1/2][FAT] miss-sync issues on sync mount (miss-sync onwrite)

[Andrew Morton]

"Machida, Hiroyuki" <machida@xxxxxxxxxxxxx> wrote:
>
> This patch fixes miss-sync issue on write() system call.
>  This updates inode attrs flags, mtime and ctime on every
>  comit_write call, due to locking.

This all seems wrong.

Why does fatfs have file_operations.write pointing at do_sync_write()
rather than generic_file_write()?

Why does fatfs have a custom .aio_write() rather than using
generic_file_aio_write()?

If fatfs can use all the standard library functions, all this inode
dirtying and O_SYNC/-o sync handling shoud just work.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/