Re: [PATCH 04/11] hpt366: write the full 4 bytes of ROM address,not just low 1 byte

From: David Lang
Date: Thu Sep 15 2005 - 05:40:18 EST


On Wed, 14 Sep 2005, Chris Wright wrote:

* David Lang (dlang@xxxxxxxxxxxxxxxxxx) wrote:
didn't Linus find similar bugs in a couple of the other hpt drivers as
well? if so can they be fixed at the same time?

Yes, and they're in this series. This patch does:

drivers/ide/pci/hpt366.c

And patch 10/11 does:

drivers/ide/pci/cmd64x.c
drivers/ide/pci/hpt34x.c

Additionally, the sungem (5/11) and sunhme (6/11) changes are fallout
from PCI_ROM fixes.

I believe the remainder of the PCI_ROM related patches were primarily
for consistency.

sorry about the noise, I read through all the descriptions looking for these, but I hadn't read all the patches.

David Lang

P.S. thanks to the kernel team for catching this before I got a chance to install .13 on my system that has a hpt374 controller :-)
--
There are two ways of constructing a software design. One way is to make it so simple that there are obviously no deficiencies. And the other way is to make it so complicated that there are no obvious deficiencies.
-- C.A.R. Hoare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/