Re: libata sata_sil broken on 2.6.13.1

From: izvekov
Date: Thu Sep 15 2005 - 15:13:57 EST


> ata_interrupt checks qc->tf.ctl & ATA_NIEN
>
> Other functions set/reset nIEN in the tf they issue then directly call
> ata_tf_load/ata_exec_* so I don't believe qc->tf.ctl is the correct
> thing to check for non-interrupt status on older type controllers at
> least.
>
> Instead you need to look at ap->last_ctl. But that too looks suspect if
> any kind of reset sets it back to an undefined state.
>

Just tried that, and it doesnt help. Doesnt change behaviour, at least for
my problem.

> Finally I don't see what locks viewing ->tf.ctl/->last_ctl against
> whether it has yet been loaded into the hardware.
>
> Alan
>

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/