Re: [RFC PATCH 1/10] vfs: Lindentified namespace.c

[Jörn Engel]

On Fri, 16 September 2005 14:39:15 -0700, Ram Pai wrote:
> On Fri, 2005-09-16 at 14:25, Andrew Morton wrote:
> > linuxram@xxxxxxxxxx (Ram) wrote:
> > >
> > > Lindentified fs/namespace.c
> > 
> > For something which is as already-close to CodingStyle as namespace.c it's
> > probably better to tidy it up by hand.  Lindent breaks almost as much stuff
> > as it fixes.
> 
> I thought Lindent was the gospel for codying style. Looks like its not.
> Will fix all of them.

It is an approximation.  In my personal experience, the "-l80"
parameter is doing a lot of harm.  It causes things like

	if (...)
		for (...)
			while (...)
				if (...)
					for (...)
						while (...)
							some_function(argument,
									very_long_argument,
									another_argument,
									0,
									1,
									NULL
									);

Code with many indentation levels is pressed hard against the 80
column limit.  Such code needs manual cleanup anyway and the 80 column
thing makes manual cleanup harder instead of easier.  Without that,
Lindent is a big initial improvement.

It is not the final word. :)

Jörn

-- 
If you're willing to restrict the flexibility of your approach,
you can almost always do something better.
-- John Carmack
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/