Re: aoe fails on sparc64

From: Roland Dreier
Date: Mon Sep 19 2005 - 13:29:45 EST


David> Although it's very much discouraged to dereference
David> unaligned pointers, especially in performance critical code
David> (which this AOE case is not, thankfully), because
David> performance will be really bad as the trap handler has to
David> fix up the access on RISC platforms.

Also, ia64 has a tendency to print an ugly message in the kernel log
for unaligned accesses. Has anyone tried AoE on ia64?

It might be better to change the AoE code to use get_unaligned(), just
to document what's going on. Although clearly the sparc64 patch is
correct as well -- we should never silently return the wrong data.

- R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/