Re: I request inclusion of reiser4 in the mainline kernel

From: Horst von Brand
Date: Mon Sep 19 2005 - 22:29:53 EST


Nikita Danilov <nikita@xxxxxxxxxxxxx> wrote:
> Denis Vlasenko writes:
> > On Friday 16 September 2005 20:05, Hans Reiser wrote:
> > > All objections have now been addressed so far as I can discern.
> >
> > Random observation:
> >
> > You can declare functions even if you never use them.
> > Thus here you can avoid using #if/#endif:
> >
> > #if defined(REISER4_DEBUG) || defined(REISER4_DEBUG_MODIFY) || defined(REISER4_DEBUG_OUTPUT)
> > int znode_is_loaded(const znode * node /* znode to query */ );
> > #endif

> It's other way around: declaration is guarded by the preprocessor
> conditional so that nobody accidentally use znode_is_loaded() outside of
> the debugging mode.

Since when has a missing declaration prevented anyone calling a function in
C?!
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/