Re: [PATCH] m32r: set CHECKFLAGS properly

[Hirokazu Takata]

Please don't specify __BIG_ENDIAN__.  ;-)
We have supported both big- and little-endian for the m32r kernel.
I hope it will be kept unconditional.

Now, the endianness is to be determined by a (cross)compiler:
- For the big-endian, a compiler (m32r-linux-gcc or m32r-linux-gnu-gcc)
  provides a predefined macro __BIG_ENDIAN__.
- For little-endian, a compiler (m32rle-linux-gcc or m32rle-linux-gnu-gcc)
  provides a predefined macro __LITTLE_ENDIAN__.

Here is a modified patch.

Thank you.

From: Al Viro <viro@xxxxxxxxxxxxxxxx>
Date: Mon, 26 Sep 2005 06:18:04 +0100
> What we do need is __BIG_ENDIAN__; right now unconditional, when m32r starts
> using CPU_LITTLE_ENDIAN, we'll need to adjust.

Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
Signed-off-by: Hirokazu Takata <takata@xxxxxxxxxxxxxx>
----
 arch/m32r/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.14-rc2/arch/m32r/Makefile
===================================================================
--- linux-2.6.14-rc2.orig/arch/m32r/Makefile	2005-08-29 08:41:01.000000000 +0900
+++ linux-2.6.14-rc2/arch/m32r/Makefile	2005-09-27 13:15:19.000000000 +0900
@@ -24,7 +24,7 @@ aflags-$(CONFIG_ISA_M32R)	+= -DNO_FPU -W
 CFLAGS += $(cflags-y)
 AFLAGS += $(aflags-y)
 
-CHECKFLAGS	:= $(CHECK) -D__m32r__
+CHECKFLAGS	+= -D__m32r__
 
 head-y	:= arch/m32r/kernel/head.o arch/m32r/kernel/init_task.o
 
--
Hirokazu Takata <takata@xxxxxxxxxxxxxx>
Linux/M32R Project:  http://www.linux-m32r.org/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/