Re: [RFC PATCH] pci_ids.h: cleanup: whitespace and remove unused entries

[Grant Coady]

On Tue, 27 Sep 2005 17:23:08 -0400, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:

>Greg KH wrote:
[...]
>>               We should start by removing the pci device and vendor ids
>> that are not currently used by the kernel, and then slowly move those
>> ids into the individual drivers, starting with the device ids, and maybe
>> eventually moving to the vendor ids.
>
>The vendor ids are OBVIOUSLY common constants.  The proper place is 
>where they live now:  pci_ids.h.
>
>I see little value in moving referenced device ids into individual 
>drivers, as they will make them harder to grep for, as time passes.

Hi Jeff,
Couple weeks ago you wrote:
 >Long term, we should be able to trim a lot of device ids, since they are 
 >usually only used in one place.

What did you mean here?  Trim from where?

Currently I have about 2011 symbols in the source, and 2040 in pci_ids.h, 
with about 15 duplicates (likely the macro #define ones).  

The situation is like the donkey between the hay bales.

Which way?

In meantime I'll continue to document current practice here:
  http://bugsplatter.mine.nu/kernel/pci_ids/

Thanks,
Grant.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/