Re: [RFC][PATCH] identify in_dev_get rcu read-side critical sections

From: Suzanne Wood
Date: Thu Sep 29 2005 - 18:40:55 EST


> From suzannew Thu Sep 29 16:30:28 2005

> > From: Herbert Xu 30 Sep 2005 07:28

> > BTW, could you please move the rcu_dereference in in_dev_get()
> > into the if clause? The barrier is not needed when ip_ptr is
> > NULL.

> The trouble with that may be that there are three events, the
> dereference, the assignment, and the conditional test. The
> rcu_dereference() is meant to assure deferred destruction
> throughout.

Sorry, I was thinking in terms of the rcu_read_lock, so this is misstated.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/