Re: [PATCH] earlier allocation of order 0 pages from pcp in__alloc_pages

From: Rohit Seth
Date: Thu Sep 29 2005 - 20:53:19 EST


On Thu, 2005-09-29 at 16:11 -0700, Andrew Morton wrote:
> "Martin J. Bligh" <mbligh@xxxxxxxxxx> wrote:
> >
> > It looks like we're now dropping into direct reclaim as the first thing
> > in __alloc_pages before even trying to kick off kswapd. When the hell
> > did that start? Or is that only meant to trigger if we're already below
> > the low watermark level?
>
> That's all the numa goop which Martin Hicks added. It's all disabled if
> z->reclaim_pages is zero (it is). However we could be testing that flag a
> bit earlier, I think.
>
> And yeah, some de-spaghettification would be nice. Certainly before adding
> more logic.
>
> Martin, should we take out the early zone reclaim logic? It's all
> unreachable at present anyway.
>
...yeah just like sys_set_zone_reclaim. was it intended to be added as
a system call?

-rohit

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/