Re: [PATCH/RFC 1/2] simple SPI framework

From: Vitaly Wool
Date: Wed Oct 05 2005 - 04:12:37 EST


Russell King wrote:

The third parameter is obsolete and should only be used to select _one_
of the tree suspend calls you will get.

Any additional suspend calls should _not_ create extra usage of this
parameter. It's a left over from Pat's first driver model incarnation
which is specific to the platform device drivers. (Mainly it exists
because no one can be bothered to clean it up.)



Oops... I mixed it with state parameter.
We need to track down the state parameter to setup wakeups.
The mixture was mostly provocated by using 'pm_message_t' instead of 'state' in David's suspend fucntion which doesn't look right to me by itself.

Vitaly

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/