Re: [PATCH 1/5] AMD Geode GX/LX support V2

From: Dave Hansen
Date: Wed Oct 05 2005 - 11:59:43 EST


On Wed, 2005-10-05 at 10:54 -0600, Jordan Crouse wrote:
> +/* This function handles National Semiconductor branded processors */
> +
> +static void __init init_nsc(struct cpuinfo_x86 *c)
> +{
> + int r;
> +
> + /* There may be GX1 processors in the wild that are branded
> + * NSC and not Cyrix.
> + *
> + * This function only handles the GX processor, and kicks
> every
> + * thing else to the Cyrix init function above - that should
> + * cover any processors that might have been branded
> differently
> + * after NSC aquired Cyrix.
> + *
> + * If this breaks your GX1 horribly, please e-mail
> + * info-linux@xxxxxxxxxxxxxxx to tell us.
> + */
> +
> + /* Handle the GX (Formally known as the GX2) */
> +
> + if ((c->x86 == 5) && (c->x86_model == 5)) {
> + r = get_model_name(c);
> + display_cacheinfo(c);
> + }
> + else
> + init_cyrix(c);
> +}

CodingStyle. Please keep the bracket and the else on the same line:

if {
foo();
} else
bar();

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/