Re: [patch 08/28] Input: prepare to sysfs integration

[Greg KH]

On Wed, Oct 05, 2005 at 05:17:00PM -0500, Dmitry Torokhov wrote:
> On 10/5/05, Greg KH <gregkh@xxxxxxx> wrote:
> > On Thu, Sep 15, 2005 at 02:01:39AM -0500, Dmitry Torokhov wrote:
> > > Input: prepare to sysfs integration
> > >
> > > Add struct class_device to input_dev; add input_allocate_dev()
> > > to dynamically allocate input devices; dynamically allocated
> > > devices are automatically registered with sysfs.
> > >
> > > Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> >
> > Ok, I've applied this one, and the other "convert the input drivers to
> > be dynamic" to my tree, as this is all great work.
> >
> > I'll work on the last few patches that you have, with regard to how to
> > tie it into sysfs "properly" now, and get back to you, just wanted to
> > apply all of these, so we have a common base to work on.
> >
> 
> Greg,
> 
> Could you please drop these patches for a while? Or maybe just don't
> push them to Linus yet.

How about I hold on to them, until you send me replacements for them?
I'm using quilt so I can just drop them and add your new ones very
easily.  I will not push them to Linus until you and Vojtech say it's ok
for me to do so.

> The reason is that I want to change input_allocate_device to take
> bitmap of supported events. This way I could allocate ABS tables
> dynamically at the same time I allocate input_dev itself and it will
> simplify error handling logic in drivers and it will save I think 1260
> bytes per input_dev structure which is nice. And I don't want to go
> through all subsystems yet again soI want to fold into my input
> dynalloc patch...

That sounds good.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/