Re: [RFC] atomic create+open

From: Trond Myklebust
Date: Thu Oct 06 2005 - 12:37:12 EST


to den 06.10.2005 Klokka 19:23 (+0200) skreiv Miklos Szeredi:
> > No, but what value does an extra function call add then when you already
> > have lookup intents?
>
> Just to provide a proper interface, and not have to extend open
> intents further.

Why do you consider an extra function call to be a more "proper
interface"?

Does it fix more races? Does it allow you to do new things more
elegantly? Does it offer a better abstraction?

Just trying to understand why you are trying to dump an interface that
has been agreed upon for several years and replace it with one that was
rejected.

> Earlier you said, that intents are meant to be optional, so this
> atomicity requirement is getting further from the "intent" concept.

No it is not. It is bang right in the middle of the intent concept.

Intents are there in order to allow the filesystem to determine which
operation is calling lookup so that it can optimise for that particular
operation.
If your filesystem is able to do lookup+create+open more efficiently
than the VFS can, then that is what it is designed to allow you to do.

Cheers,
Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/