Re: [PATCH] don't invalidate non-directory mountpoints

From: Al Viro
Date: Fri Oct 07 2005 - 09:30:49 EST


On Fri, Oct 07, 2005 at 01:13:50PM +0200, Miklos Szeredi wrote:
> d_invalidate allowed a non-directory mountpoint to be invalidated,
> which is bad, since the mountpoint becomes unreachable.
>
> I know it's racy wrt attaching/detaching mount, but AFAICS so is
> everything else that unhashes the dentry. This seems to be an
> oversight when splitting out vfsmount_lock from dcache_lock. To be
> fixed.

NAK. That's a wrong way to deal with the problem and it's much older
than vfsmount_lock or dcache_lock (and affects directories too).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/