Re: [PATCH] nfs: don't drop dentry in d_revalidate

From: Al Viro
Date: Fri Oct 07 2005 - 09:39:13 EST


On Fri, Oct 07, 2005 at 01:21:01PM +0200, Miklos Szeredi wrote:
> NFS d_revalidate() is doing things that are supposed to be done by
> d_invalidate().
>
> Dropping the dentry is especially bad, since it will make
> d_invalidate() bypass all checks.

NAK. _IF_ you are going to start playing with that area, start with
handling that stuff in caller before going after methods.

Note that the only relatively sane semantics is to have equivalent on
umount -l done to everything that becomes unreachable.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/