Re: [patch] yenta: fix YENTA && !CARDBUS build

From: Russell King
Date: Fri Oct 07 2005 - 14:17:00 EST


On Fri, Oct 07, 2005 at 06:34:15PM +0200, Jiri Slaby wrote:
> On 10/7/05, David Vrabel <dvrabel@xxxxxxxxxx> wrote:
> > (Previous patch left a warning.)
> >
> > yenta_socket no longer builds if CONFIG_CARDBUS is disabled. It doesn't
> > look like ene_tune_bridge is relevant in the !CARDBUS configuration so
> > I've just disabled it.
> >
> >
> > yenta: fix build if YENTA && !CARDBUS
> >
> > (struct pcmcia_socket).tune_bridge only exists if CONFIG_CARDBUS is set but
> > building yenta_socket without CardBus is valid.
> >
> This is a multi-part message in MIME format.
>
> Are you really sure, that you have read Documentation/SubmittingPatches and
> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
> Nobody wants MIMEs. Include it as plain text

You're providing misleading advice. mimes are acceptable provided
each part is text/plain. And some folk need to attach rather than
inline patches to prevent white space damage from broken mailers.

And indeed David's were text/plain so there isn't a problem.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/