Re: [PATCH] Fix hotplug cpu on x86_64

From: Andi Kleen
Date: Sat Oct 08 2005 - 05:31:39 EST


On Saturday 08 October 2005 02:50, Anton Blanchard wrote:
> Hi,
>
> > I also have a followon patch to avoid the extreme memory wastage
> > currently caused by hotplug CPUs (e.g. with NR_CPUS==128 you currently
> > lose 4MB of memory just for preallocated per CPU data). But that is
> > something for post 2.6.14.
>
> Im interested in doing that on ppc64 too. Are you currently only
> creating per cpu data areas for possible cpus?

Yes. In fact that caused some of the problems that lead to the investigation
of this.

> The generic code does
> NR_CPUS worth, we should change that in 2.6.15.

You need to audit all architecture code then that fills up possible map.
(at least for the architectures that support CPU hotplug)

With that change x86-64 could move back to the generic code BTW -
the numa allocation in the architecture specific code doesn't work anymore
because we usually find out about the cpu<->node mapping now only
afterwards :/

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/