Re: [PATCH] Doc/MSI-HOWTO: cleanups
From: Roland Dreier
Date: Sat Oct 08 2005 - 19:56:17 EST
This file can definitely use some rewriting, so thanks for doing this
work. I'm just picking on some things I notice while reading your patch:
> masking is an optional extension of MSI but a required
> feature for MSI-X. Per-vector masking provides the kernel
> the ability to mask/unmask MSI when servicing its software
> - interrupt service routing handler. If per-vector masking is
> + interrupt service routine handler. If per-vector masking is
> not supported, then the device driver should provide the
> hardware/software synchronization to ensure that the device
> generates MSI when the driver wants it to do so.
If you're going to touch this at all, it should be rewritten so it
actually makes sense. I would rewrite this sentence as either
"...the ability to mask/unmask a single MSI while servicing its
"...the ability to mask/unmask a single MSI while running its
interrupt service routine."
> +With this new API, any existing device driver which wants to have
> +MSI enabled on its device function must call this API to enable MSI.
"device function" (which is PCI jargonese) should probably just be
"device." Also, perhaps "...a device driver that..." would read
better than "...any existing device driver which...."
> pre-assigned dev->irq with a new MSI vector. To avoid the conflict
> -of new assigned vector with existing pre-assigned vector requires
> +of the new assigned vector with existing pre-assigned vector requires
> a device driver to call this API before calling request_irq().
"...the conflict..." should probably be "...a conflict..."
> +software system can set different pages for controlling accesses to the
> +MSI-X structure. The implementation of the MSI patch requires the PCI
"...the MSI patch..." should probably be "...MSI support..."
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/